db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6125) Code clean up in client driver.
Date Tue, 02 Apr 2013 06:51:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619565#comment-13619565
] 

Knut Anders Hatlen commented on DERBY-6125:
-------------------------------------------

Thanks for cleaning up this code, Dag.

After the 04-a patch, these three methods in NetConnection do nothing except calling the method
with the same name in the super class:

  - close()
  - closeX()
  - closeResources()

Should we just remove them now and let NetConnection inherit them from its super class? (Slightly
related: If we remove these methods from NetConnection, we could also make Connection.closeX()
private and unsynchronized, as it will only be called from Connection.close().)

The patch also touches NetConnection's closeForReuse() method, which doesn't have any callers
as far as I can see. Remove that one too?
                
> Code clean up in client driver.
> -------------------------------
>
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, derby-6125-01-b.status,
derby-6125-02-a.diff, derby-6125-02-a.status, derby-6125-03-a.diff, derby-6125-03-a.status,
derby-6125-04-a.diff, derby-6125-04-a.status, derby-6125-05-a.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message