db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-6125) Code clean up in client driver.
Date Wed, 10 Apr 2013 12:40:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dag H. Wanvik updated DERBY-6125:
---------------------------------

    Attachment: derby-6125-imports-01-a.status
                derby-6125-imports-01-a.diff

Uploading derby-6125-imports-01-a. This "horizontal" patch makes the import policy consistent
for the client driver:

- iff a class from java.sql.* can be shadowed by a Derby class (i.e. Clob, ResultSet); we
do not import such java.sql.* classes but refer to them using the full package and class name.
The Derby classes are always imported and referenced in the short form. This makes the code
much more readable IMHO.

- I'd like to change the names of the Derby classes that can shadow java.sql.* classes (so
we can import such classes from java.sql.* too), but I need to investigate whether that can
have any compatibility issues first. Does anyone know?

Otherwise, the patch contains a few Javadoc improvements and typo fixes.

Regressions ran OK.


                
> Code clean up in client driver.
> -------------------------------
>
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff, derby-6125-01-b.diff, derby-6125-01-b.status,
derby-6125-02-a.diff, derby-6125-02-a.status, derby-6125-03-04-followup.diff, derby-6125-03-04-followup.status,
derby-6125-03-a.diff, derby-6125-03-a.status, derby-6125-04-a.diff, derby-6125-04-a.status,
derby-6125-05-a.diff, derby-6125-05-c.diff, derby-6125-05-c.status, derby-6125-05-d.diff,
derby-6125-05-d.status, derby-6125-imports-01-a.diff, derby-6125-imports-01-a.status, derby-6125-visibility-01-a.diff,
derby-6125-visibility-01-a.status, derby-6125-visibility-01-b.diff
>
>
> Clean up unused code, lacking finals, too wide visibility etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message