db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6125) Code clean up in client driver.
Date Fri, 22 Mar 2013 09:47:19 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610072#comment-13610072

Knut Anders Hatlen commented on DERBY-6125:

All of the changes in the 01-a patch look good to me. +1.

In the Configuration class, traceLevel__, traceFile__, traceDirectory__, traceFileAppend__
(and also traceFileSuffixIndex__ which was not touched by the patch) are essentially unused.
There's some code that's executed if they are non-null, but that won't ever happen. Maybe
we could just remove that dead code while we're at it.
> Code clean up in client driver.
> -------------------------------
>                 Key: DERBY-6125
>                 URL: https://issues.apache.org/jira/browse/DERBY-6125
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6125-01-a.diff
> Clean up unused code, lacking finals, too wide visibility etc.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message