db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-3838) Convert derbynet/DerbyNetAutoStart to JUnit
Date Tue, 26 Mar 2013 16:31:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614175#comment-13614175
] 

Myrna van Lunteren commented on DERBY-3838:
-------------------------------------------

Thanks for the review Dag.
You're right, re the expected server up - it should be expecting true...

However, I don't think that is the section causing the 4 mins elapsed time.
Instead, if I eliminate the final check in the fixture testStartNetworkServerLogMessageOnDualStart:
        ns.shutdown();
        assertFalse(NetworkServerTestSetup.pingForServerUp(ns, null, false));
then the fixture takes about 2 seconds instead of 2.5 mins on my system.
I don't think that check (to see if the server was really down) is very useful, and certainly
not worth that much time. I'll eliminate it.
I'll run full tests.



                
> Convert derbynet/DerbyNetAutoStart to JUnit
> -------------------------------------------
>
>                 Key: DERBY-3838
>                 URL: https://issues.apache.org/jira/browse/DERBY-3838
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.5.1.1
>            Reporter: Erlend Birkenes
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3838_2.diff, DERBY-3838.diff, DERBY-3838.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message