db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-6086) Factor out logic for creating custom connection in jdbcapi.StatementPoolingTest
Date Fri, 22 Feb 2013 07:12:12 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584038#comment-13584038
] 

Dag H. Wanvik edited comment on DERBY-6086 at 2/22/13 7:10 AM:
---------------------------------------------------------------

Looks like a good cleanup. +1 Nit: I'd drop this line (process comment, not code comment):

+        // Seven was used in the tests already, chose to use it as default.

                
      was (Author: dagw):
    Looks like a good cleanup. +1 Nit: I'd drop this line (process meta-comment, not code
comment):

+        // Seven was used in the tests already, chose to use it as default.

                  
> Factor out logic for creating custom connection in jdbcapi.StatementPoolingTest
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-6086
>                 URL: https://issues.apache.org/jira/browse/DERBY-6086
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.10.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-6086-1a-logical_con_boilerplate.diff
>
>
> There is quite a bit of common boilerplate code in jdbcapi.StatementPoolingTest related
to getting a custom connection, or rather more than one logical connection from a single pooled
(physical) connection.
> This could be factored out to make the test methods shorter, and to make the test methods
more focused on whatever they're testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message