db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-6066) Client should use a prepared statement rather than regular statement for Connection.getTransactionIsolation
Date Wed, 20 Feb 2013 17:05:15 GMT

    [ https://issues.apache.org/jira/browse/DERBY-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582328#comment-13582328
] 

Mamta A. Satoor commented on DERBY-6066:
----------------------------------------

Hi Knut, TableLockBasicTest did not belong in the earlier patch. I had that diff left over
from various different expirements I was trying to figure out why we never get into the part
of the code in o.a.d.client.am.Connection.getTransactionIsolationX where we create statement(with
my changes, PreparedStatement) for "VALUES CURRENT ISOLATION". 

In trunk, I had put println in the code where we create the statement for "VALUES CURRENT
ISOLATION" and ran junit suite and saw that we never print that string. I looked through various
related commits in this area and found the jira after which we have stopped coming into create
statement code. That change went in 10.7 as part of DERBY-4314(With derby client setTrasactionIsolation
executes and commits even if isolation has not changed.) as checkin r940620. When I put the
println in 10.6 client, I can see while running junit that we spit out the println(10.6 doesn't
have changes for DERBY-4314). I am not sure if the changes for DERBY-4314 have made the create
statement code dead and it is not needed anymore(since isolation is received through piggybacking)
or if there is a bug which prevents us from going into the create statement code.

I will attach the latest patch for this jira which simply uses PreparedStatement rather than
Statement.

Also, I have created DERBY-6082 to see if openOnServer_ in org.apache.derby.client.am.Statement
is still needed. If not, then we can remove it from the if statement for statement creation
for "VALUES CURRENT ISOLATION".
                
> Client should use a prepared statement rather than regular statement for Connection.getTransactionIsolation
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-6066
>                 URL: https://issues.apache.org/jira/browse/DERBY-6066
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY6066_patch1_diff.txt
>
>
> This jira is similar to DERBY-6053 but for o.a.d.client.am.Connection.getTransactionIsolation.
Use prepared statement rather than regular statement every time user makes a get transaction
isolation call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message