Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Mon, 19 Nov 2012 13:24:58 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <2113631086.2720.1353331498375.JavaMail.jiratomcat@arcas>
Subject: [jira] [Closed] (DERBY-2920) Share code between readExternal() and
 readExternalFromArray()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen closed DERBY-2920.
-------------------------------------

    Resolution: Fixed

Committed revision 1411164.
                
> Share code between readExternal() and readExternalFromArray()
> -------------------------------------------------------------
>
>                 Key: DERBY-2920
>                 URL: https://issues.apache.org/jira/browse/DERBY-2920
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services, SQL
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>              Labels: derby_triage10_10
>             Fix For: 10.10.0.0
>
>         Attachments: d2920-1a.diff, d2920-2a-unused.diff, ReadInts2.java, ReadInts.java
>
>
> Most of the implementations of DataValueDescriptor.readExternalFromArray(ArrayInputStream) are identical to their corresponding Externalizable.readExternal(ObjectInput) methods. Since ArrayInputStream implements ObjectInput, readExternalFromArray() could in those cases just have forwarded calls to readExternal() instead of duplicating the code. A default forwarding implementation of readExternalFromArray() could be placed in org.apache.derby.iapi.types.DataType, and all the existing implementations, except those with optimizations for ArrayInputStream, could be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira