Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Wed, 31 Oct 2012 12:13:12 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <814933407.49971.1351685592301.JavaMail.jiratomcat@arcas>
Subject: [jira] [Created] (DERBY-5971) Improve test coverage for SQLBoolean
 class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Knut Anders Hatlen created DERBY-5971:
-----------------------------------------

             Summary: Improve test coverage for SQLBoolean class
                 Key: DERBY-5971
                 URL: https://issues.apache.org/jira/browse/DERBY-5971
             Project: Derby
          Issue Type: Improvement
          Components: Test
    Affects Versions: 10.10.0.0
            Reporter: Knut Anders Hatlen
            Assignee: Knut Anders Hatlen
            Priority: Minor


When looking at a test coverage report, I noticed that these methods in the SQLBoolean class are not tested:

- falseTruthValue
- trueTruthValue
- greaterOrEquals
- greaterThan
- lessOrEquals
- lessThan
- is
- isNot
- readExternal
- hashCode

falseTruthValue() and trueTruthValue() are never called anywhere in the code and could be removed.

is() and isNot() also have no callers. However, they implement the boolean IS operator which is part of the SQL standard, so it might make more sense to file a JIRA to add the syntax to the grammar rather than removing the methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira