Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08CBCD239 for ; Thu, 6 Sep 2012 19:51:08 +0000 (UTC) Received: (qmail 60161 invoked by uid 500); 6 Sep 2012 19:51:07 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 60104 invoked by uid 500); 6 Sep 2012 19:51:07 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 59993 invoked by uid 99); 6 Sep 2012 19:51:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 19:51:07 +0000 Date: Fri, 7 Sep 2012 06:51:07 +1100 (NCT) From: "Myrna van Lunteren (JIRA)" To: derby-dev@db.apache.org Message-ID: <1067921733.46405.1346961067718.JavaMail.jiratomcat@arcas> In-Reply-To: <1826869079.9703.1346201047489.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (DERBY-5912) testIsValidImplemented fails for NetworkServer in some slow running machines/configurations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449989#comment-13449989 ] Myrna van Lunteren commented on DERBY-5912: ------------------------------------------- committed with revision: http://svn.apache.org/viewvc?view=revision&revision=1381731 The change to ConnectionMethodsTest can be backported to 10.9 and 10.8 if needed (and the name correction in the comment in ConnectionTest) . > testIsValidImplemented fails for NetworkServer in some slow running machines/configurations > ------------------------------------------------------------------------------------------- > > Key: DERBY-5912 > URL: https://issues.apache.org/jira/browse/DERBY-5912 > Project: Derby > Issue Type: Bug > Components: Test > Affects Versions: 10.8.2.3 > Reporter: Kathey Marsden > Assignee: Myrna van Lunteren > Fix For: 10.8.2.3, 10.9.1.1, 10.10.0.0 > > Attachments: DERBY-5912_2.diff, DERBY-5912.diff > > > The following test has been seen to fail as below in some runs where the machine is under heavy load and slow running options are specified and the isValid() call takes more than a second to return. > 1) testIsValidImplemented(org.apache.derbyTesting.functionTests.tests.jdbc4.ConnectionTest)junit.framework.AssertionFailedError > at org.apache.derbyTesting.functionTests.tests.jdbc4.ConnectionTest.testIsValidImplemented(ConnectionTest.java:168) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) > at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113) > at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) > at junit.extensions.TestSetup$1.protect(TestSetup.java:19) > at junit.extensions.TestSetup.run(TestSetup.java:23) > at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57) > at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) > at junit.extensions.TestSetup$1.protect(TestSetup.java:19) > at junit.extensions.TestSetup.run(TestSetup.java:23) > The test does: > // Test with a 1 second timeout > assertTrue(getConnection().isValid(1)); > assuming it will return in one second. For embedded the int parameter is not implemented so indeed this always passes. For the Network implementation in NetConnection40.java we actually do timeout and perform a query as part of the implementation so might indeed return false. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira