From derby-dev-return-97353-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Tue Aug 7 22:29:11 2012 Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 559A7D54F for ; Tue, 7 Aug 2012 22:29:11 +0000 (UTC) Received: (qmail 84729 invoked by uid 500); 7 Aug 2012 22:29:11 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 84691 invoked by uid 500); 7 Aug 2012 22:29:11 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 84633 invoked by uid 99); 7 Aug 2012 22:29:11 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2012 22:29:11 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id E2F35142855 for ; Tue, 7 Aug 2012 22:29:10 +0000 (UTC) Date: Tue, 7 Aug 2012 22:29:10 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: <1904965008.1755.1344378550933.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1881182238.313.1344346269037.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (DERBY-5896) Change java/drda source code to use spaces instead of tabs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430689#comment-13430689 ] Dag H. Wanvik commented on DERBY-5896: -------------------------------------- I'm +1 to this change. Just a question.. why are we doing it only for this part of the source? > Change java/drda source code to use spaces instead of tabs > ----------------------------------------------------------- > > Key: DERBY-5896 > URL: https://issues.apache.org/jira/browse/DERBY-5896 > Project: Derby > Issue Type: Improvement > Components: Network Server > Affects Versions: 10.10.0.0 > Reporter: Kathey Marsden > Assignee: Kathey Marsden > Attachments: derby-5896_diff.txt, derby-5896_stat.txt > > > Change all the network server code under java/drda to use spaces instead of tabs. > Having mixed tabs and spaces can be confusing, irritating and time consuming for developers especially in the network code where client is all spaces and the server mostly tabs. > With the -x -b options on svn merge and svn diff, merges should be reasonable even if we change all the tabs to 4 spaces in the files under java/drda with a script something like (not yet tried): > #!/bin/bash > files=$@ > for file in $files > { > echo $file > mv $file $file.orig > sed -e 's/\t/ /g' < $file.orig > $file > rm $file.orig > } > Are there any objections to this change? If not does anyone have any pending DRDA changes they would like to get in before I make the change? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira