db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-5896) Change java/drda source code to use spaces instead of tabs and clean up tab creep in java/client
Date Tue, 14 Aug 2012 22:25:38 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kathey Marsden resolved DERBY-5896.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.10.0.0

Resolving for trunk with the following revisions:
Thank you Knut for fixing the alignment!

http://svn.apache.org/viewvc?view=revision&amp;revision=1370674
------------------------------------------------------------------------
r1370674 | kmarsden | 2012-08-07 23:54:46 -0700 (Tue, 07 Aug 2012) | 3 lines

DERBY-5896 Change java/drda source code to use  spaces instead of tabs


------------------------------------------------------------------------
http://svn.apache.org/viewvc?view=revision&amp;revision=1371306
------------------------------------------------------------------------
r1371306 | kmarsden | 2012-08-09 09:41:32 -0700 (Thu, 09 Aug 2012) | 5 lines

DERBY-5896 Change java/drda source code to use spaces instead of tabs and clean up tab creep
in java/client

Change client tabs to spaces.


------------------------------------------------------------------------
http://svn.apache.org/viewvc?view=revision&amp;revision=1372814
------------------------------------------------------------------------
r1372814 | kahatlen | 2012-08-14 02:53:09 -0700 (Tue, 14 Aug 2012) | 4 lines

DERBY-5896: Change java/drda source code to use spaces instead of tabs and clean up tab creep
in java/client

Align with tab stops if the replaced tab character itself wasn't located on a tab stop.

------------------------------------------------------------------------
http://svn.apache.org/viewvc?view=revision&amp;revision=1372841
------------------------------------------------------------------------
r1372841 | kahatlen | 2012-08-14 04:17:14 -0700 (Tue, 14 Aug 2012) | 4 lines

DERBY-5896: Change java/drda source code to use spaces instead of tabs and clean up tab creep
in java/client

Align with tab stops in java/client.

------------------------------------------------------------------------
http://svn.apache.org/viewvc?view=revision&amp;revision=1372818
------------------------------------------------------------------------
r1372818 | kahatlen | 2012-08-14 03:05:00 -0700 (Tue, 14 Aug 2012) | 4 lines

DERBY-5896: Change java/drda source code to use spaces instead of tabs and clean up tab creep
in java/client

Align with tab stops if the replaced tab character itself wasn't located on a tab stop.

------------------------------------------------------------------------
                
> Change java/drda source code to use  spaces instead of tabs and clean up tab creep in
java/client
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5896
>                 URL: https://issues.apache.org/jira/browse/DERBY-5896
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>             Fix For: 10.10.0.0
>
>         Attachments: derby-5896-align-with-tab-stops.diff.txt, derby-5896-client-align-with-tab-stops.diff.txt,
derby-5896_client_diff.txt, derby-5896_client_stat.txt, derby-5896_diff.txt, derby-5896_stat.txt
>
>
> Change all the network server code under java/drda to use spaces instead of tabs.
> Having mixed tabs and spaces can be confusing, irritating  and time consuming for developers
especially in the network code where client is all spaces and the server mostly tabs.
> With the  -x -b options on svn merge and svn diff, merges should be reasonable even if
we change all the tabs to 4 spaces in the files under java/drda with a script something like
(not yet tried):
> #!/bin/bash
> files=$@
> for file in $files
> {
>    echo $file
>    mv  $file $file.orig
>    sed -e 's/\t/    /g' < $file.orig > $file
>    rm $file.orig
> }
> Are there any objections to this change?  If not does anyone have any pending DRDA changes
they would like to get in before I make the change?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message