db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5896) Change java/drda source code to use spaces instead of tabs and clean up tab creep in java/client
Date Thu, 09 Aug 2012 17:08:19 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431981#comment-13431981

Kathey Marsden commented on DERBY-5896:

I have made the changes for this issue, but am leaving it open for a bit while I explore options
to mitigate the large diff for annotation, merges, etc.

In eclipse, subclipse annotate (right click, team -> Show annotation)  does not currently
 have an option to ignore white space.  You can however see older annotation without switching
to 10.8.  Instead of choosing the default to Revision: HEAD, I can choose revision 1370673
and see the older revision history. It might be useful to have a label for the prereformat
so folks don't have to remember a number.

There is a subclipse issue filed: http://subclipse.tigris.org/issues/show_bug.cgi?id=1200
but looks stuck as javaHL does not expose these options.

> Change java/drda source code to use  spaces instead of tabs and clean up tab creep in
> -------------------------------------------------------------------------------------------------
>                 Key: DERBY-5896
>                 URL: https://issues.apache.org/jira/browse/DERBY-5896
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions:
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: derby-5896_client_diff.txt, derby-5896_client_stat.txt, derby-5896_diff.txt,
> Change all the network server code under java/drda to use spaces instead of tabs.
> Having mixed tabs and spaces can be confusing, irritating  and time consuming for developers
especially in the network code where client is all spaces and the server mostly tabs.
> With the  -x -b options on svn merge and svn diff, merges should be reasonable even if
we change all the tabs to 4 spaces in the files under java/drda with a script something like
(not yet tried):
> #!/bin/bash
> files=$@
> for file in $files
> {
>    echo $file
>    mv  $file $file.orig
>    sed -e 's/\t/    /g' < $file.orig > $file
>    rm $file.orig
> }
> Are there any objections to this change?  If not does anyone have any pending DRDA changes
they would like to get in before I make the change?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message