db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5896) Change java/drda source code to use spaces instead of tabs and clean up tab creep in java/client
Date Mon, 13 Aug 2012 09:35:38 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433025#comment-13433025
] 

Knut Anders Hatlen commented on DERBY-5896:
-------------------------------------------

Sorry for commenting so late. Using sed to replace tabs with exactly four spaces won't do
the right thing in all cases, as there may be less than four characters up to the next tab
stop. A tool such as expand (part of GNU coreutils) would handle the cases where the tab is
not located exactly at a tab stop. But I guess in most of the cases the script will produce
ok results, as most of the tabs are at the beginning of the line. If some lines end up oddly
formatted, we can reformat them as we come across them. Thanks for making this change.
                
> Change java/drda source code to use  spaces instead of tabs and clean up tab creep in
java/client
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5896
>                 URL: https://issues.apache.org/jira/browse/DERBY-5896
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: derby-5896_client_diff.txt, derby-5896_client_stat.txt, derby-5896_diff.txt,
derby-5896_stat.txt
>
>
> Change all the network server code under java/drda to use spaces instead of tabs.
> Having mixed tabs and spaces can be confusing, irritating  and time consuming for developers
especially in the network code where client is all spaces and the server mostly tabs.
> With the  -x -b options on svn merge and svn diff, merges should be reasonable even if
we change all the tabs to 4 spaces in the files under java/drda with a script something like
(not yet tried):
> #!/bin/bash
> files=$@
> for file in $files
> {
>    echo $file
>    mv  $file $file.orig
>    sed -e 's/\t/    /g' < $file.orig > $file
>    rm $file.orig
> }
> Are there any objections to this change?  If not does anyone have any pending DRDA changes
they would like to get in before I make the change?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message