db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5896) Change java/drda source code to use spaces instead of tabs
Date Tue, 07 Aug 2012 23:31:11 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430724#comment-13430724
] 

Kathey Marsden commented on DERBY-5896:
---------------------------------------

With all of the cleanup Knut has been doing in the drda source and the fact that client is
all spaces it seemed like a good time to do this for at least drda even if it will make merges
hard.  Hopefully though merges will be easy   with the -x -b option. I couldn't really test
this without checking in, so thought I would start with drda which I think is worth it even
if it does cause merge pain points and see how merging a few changes goes.  If merges are
not problematic with -x -b then I am totally in favor of doing the whole thing.  

Also I am  just taking it slow so everyone is comfortable. I remember a failed attempt at
 reformatting some years ago. I realize now, tabs  were the real problem as other formatting
inconsistencies are easier to negotiate. I  hoping we can eliminate the tabs now, starting
with this patch.





                
> Change java/drda source code to use  spaces instead of tabs
> -----------------------------------------------------------
>
>                 Key: DERBY-5896
>                 URL: https://issues.apache.org/jira/browse/DERBY-5896
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: derby-5896_diff.txt, derby-5896_stat.txt
>
>
> Change all the network server code under java/drda to use spaces instead of tabs.
> Having mixed tabs and spaces can be confusing, irritating  and time consuming for developers
especially in the network code where client is all spaces and the server mostly tabs.
> With the  -x -b options on svn merge and svn diff, merges should be reasonable even if
we change all the tabs to 4 spaces in the files under java/drda with a script something like
(not yet tried):
> #!/bin/bash
> files=$@
> for file in $files
> {
>    echo $file
>    mv  $file $file.orig
>    sed -e 's/\t/    /g' < $file.orig > $file
>    rm $file.orig
> }
> Are there any objections to this change?  If not does anyone have any pending DRDA changes
they would like to get in before I make the change?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message