db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-1400) Cleanup code in network server's DRDAStatement class
Date Thu, 09 Aug 2012 20:46:20 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432132#comment-13432132
] 

Myrna van Lunteren commented on DERBY-1400:
-------------------------------------------

I did a visual check of the patch, and it seems to do the same as before, while removing the
variables. +1 to commit (assuming the tests run ok).
                
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
>                 Key: DERBY-1400
>                 URL: https://issues.apache.org/jira/browse/DERBY-1400
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.1.3.1, 10.2.1.6
>            Reporter: Deepa Remesh
>            Assignee: Kathey Marsden
>            Priority: Trivial
>         Attachments: DERBY-1400.diff, derby-1400_diff.txt
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are
derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize
just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to
modify the comments at places it is currently called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message