Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21832CF40 for ; Tue, 3 Jul 2012 05:06:03 +0000 (UTC) Received: (qmail 278 invoked by uid 500); 3 Jul 2012 05:06:03 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 106 invoked by uid 500); 3 Jul 2012 05:06:02 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 99978 invoked by uid 99); 3 Jul 2012 05:06:01 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2012 05:06:01 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id AB0CF142822 for ; Tue, 3 Jul 2012 05:06:01 +0000 (UTC) Date: Tue, 3 Jul 2012 05:06:01 +0000 (UTC) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Message-ID: <260219897.238.1341291961702.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1481855866.60646.1340780384027.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Resolved] (DERBY-5834) Remove unused methods in NetPreparedStatement class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pendleton resolved DERBY-5834. ------------------------------------ Resolution: Fixed Fix Version/s: 10.10.0.0 Assignee: Mohamed Nufail This patch looks great to me. I agree with the observation that these overloads of the resetNetPreparedStatement method are unused, and should be removed. My builds and tests were successful, and I've committed this patch to the trunk as revision 1356573. > Remove unused methods in NetPreparedStatement class > --------------------------------------------------- > > Key: DERBY-5834 > URL: https://issues.apache.org/jira/browse/DERBY-5834 > Project: Derby > Issue Type: Task > Components: Network Client > Reporter: Mohamed Nufail > Assignee: Mohamed Nufail > Priority: Minor > Fix For: 10.10.0.0 > > Attachments: derby-5834.patch > > > The following two methods in NetPreparedStatement class are never used. It might be possible to remove them. > - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section) > - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira