Return-Path: 
 <derby-dev-return-96887-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
X-Original-To: apmail-db-derby-dev-archive@www.apache.org
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 229E0D302
	for <apmail-db-derby-dev-archive@www.apache.org>;
 Fri,  6 Jul 2012 15:03:40 +0000 (UTC)
Received: (qmail 9698 invoked by uid 500); 6 Jul 2012 15:03:38 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 7968 invoked by uid 500); 6 Jul 2012 15:03:36 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 7896 invoked by uid 99); 6 Jul 2012 15:03:35 -0000
Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jul 2012 15:03:35 +0000
Received: from isssues-vm.apache.org (localhost [127.0.0.1])
	by issues-vm (Postfix) with ESMTP id 06C7B14035F
	for <derby-dev@db.apache.org>; Fri,  6 Jul 2012 15:03:35 +0000 (UTC)
Date: Fri, 6 Jul 2012 15:03:35 +0000 (UTC)
From: "Dag H. Wanvik (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <2122435196.14335.1341587015030.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1273656628.9984.1341510995345.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (DERBY-5849) Text for SQL state XSDG0: remove
 redundant "page"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DERBY-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408048#comment-13408048 ] 

Dag H. Wanvik commented on DERBY-5849:
--------------------------------------

Would something like this look better:

The page with page key "Page(1,Container(0, 14929))" could not be read from disk.

We would then need to localize the text "The page with page key" for our supported languages. Page key is an implementation entity (class PageKey). Would it be beneficial to explain what the numbers mean in the error message? E.g. 

The page identified by page number 1 in the container identified by container id 14929, segment 0, could not be read from disk."

Opinions?

                
> Text for SQL state XSDG0: remove redundant "page"
> -------------------------------------------------
>
>                 Key: DERBY-5849
>                 URL: https://issues.apache.org/jira/browse/DERBY-5849
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services, Store
>            Reporter: Dag H. Wanvik
>            Priority: Trivial
>
> In the message text (English locale), we see this error being printed for error state XSDG0:
>    Page Page(1,Container(0, 14929)) could not be read from disk. 
> The text in messages.xml is:
>    <text>Page {0} could not be read from disk.</text>
> The problem is that the argument used is a PageKey, which has a toString method thats prints:
>    "Page(" + pageNumber + "," + container.toString() + ")";
> so, we get two "page" string and it looks silly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira