Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Mon, 9 Jul 2012 12:56:34 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <1969357812.22597.1341838594945.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <2075344431.3785.1341421595798.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (DERBY-5847) Clean up IDE warnings in
 DRDAConnThread
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-5847:
--------------------------------------

    Attachment: d5847-3a-static-fields-and-imports.patch

Attaching d5847-3a-static-fields-and-imports.patch which fixes the references to static fields and organizes the imports alphabetically. This is also a partial fix for DERBY-436 (partial since it only touches DRDAConnThread, whereas that issue is for all the DRDA classes).

Somewhat related, but not actually addressing any warnings, the patch also replaces references to fields in JDBC30Translation with java.sql.ParameterMetaData, as the ParameterMetaData interface has been available on the minimum compiler level for the DRDA code for quite a while now.

Regression tests ran cleanly with the patch.
                
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
>                 Key: DERBY-5847
>                 URL: https://issues.apache.org/jira/browse/DERBY-5847
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5847-1a-string-equality.patch, d5847-2a-unnecessary-return.patch, d5847-3a-static-fields-and-imports.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are harmless (like static fields accessed via an instance, suggestions about using StringBuilder instead of StringBuffer, or using System.arraycopy() instead of for loops). Others indicate real problems, like the use of != to compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings about potential problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira