db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5827) Remove unused methods in NetStatementReply class
Date Sun, 01 Jul 2012 22:44:08 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404849#comment-13404849
] 

Bryan Pendleton commented on DERBY-5827:
----------------------------------------

I am reviewing this patch.

I looked at the svn history of NetStatementReply.java 
http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java?view=annotate
and all of these methods seem to have been present since
the original contribution of this class to Derby, and have not been
modified since.

I also independently searched the code, and I agree that these
methods are entirely unused.

I'm intending to commit this patch. Deleting this unused code seems
fine, since the original implementation is still preserved in svn in case
we want to revive any of these methods in the future.

                
> Remove unused methods in NetStatementReply class
> ------------------------------------------------
>
>                 Key: DERBY-5827
>                 URL: https://issues.apache.org/jira/browse/DERBY-5827
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>            Reporter: Mohamed Nufail
>            Priority: Minor
>         Attachments: DERBY-5827.patch
>
>
> Code inspection of the NetStatementReply class shows that the following methods are not
used at all. 
> parseQRYPRCTYP()
> parseSQLCSRHLD()
> parseQRYATTSCR()
> parseQRYATTSET()
> parseQRYATTSNS()
> parseQRYATTUPD()
> So it might be possible to remove these methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message