db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5843) Remove unused method in CharacterStreamDescriptor
Date Mon, 09 Jul 2012 17:07:35 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409643#comment-13409643
] 

Kathey Marsden commented on DERBY-5843:
---------------------------------------

Removing a  toString() method might be a bit tricky as it is not always invoked with the toString()
method explicitly but rather would also be called by just adding the object to an output stream
(probably the derby.log)  by just adding  + csd where csd is a CharacterStreamDescriptor object.

Such verbose output can occur with some of the debug properties, e.g:
http://wiki.apache.org/db-derby/DebugPropertiesTmpl

I don't know that that this particular object is ever printed with the debug options or a
good way to check if it is.  Also I know where toString()  exist I have found them convenient
when looking at values in the debugger.  I think I would be a bit wary of removing toString()
methods. 

Just my opinion though.



                
> Remove unused method in CharacterStreamDescriptor
> -------------------------------------------------
>
>                 Key: DERBY-5843
>                 URL: https://issues.apache.org/jira/browse/DERBY-5843
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Siddharth Srivastava
>            Assignee: Siddharth Srivastava
>            Priority: Minor
>         Attachments: Derby5843.patch
>
>
> Following function is not used:
> public String toString()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message