db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5847) Clean up IDE warnings in DRDAConnThread
Date Tue, 10 Jul 2012 14:48:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410393#comment-13410393
] 

Knut Anders Hatlen commented on DERBY-5847:
-------------------------------------------

Thanks, Bryan. In general, I agree that it's better to delete unused code. But in this particular
case, I felt that the code had some value documenting the fact that the protocol requires
us to send a specific reply message, but because of a bug we cannot do that. (Assuming that
the protocol actually requires a RDBUPDRM here, but I haven't checked that.) On the other
hand, it might be OK to remove the code and just insert a comment saying that we're violating
the protocol.
                
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
>                 Key: DERBY-5847
>                 URL: https://issues.apache.org/jira/browse/DERBY-5847
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5847-1a-string-equality.patch, d5847-2a-unnecessary-return.patch,
d5847-3a-static-fields-and-imports.patch, d5847-4a-unused-assignment.patch, d5847-5a-performance-warnings.patch,
d5847-6a-obsolete-collection.patch, d5847-7a-sync-on-non-final.patch, d5847-8a-misc.patch,
d5847-9a-this-leak.patch, d5847-9b-this-leak.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are harmless
(like static fields accessed via an instance, suggestions about using StringBuilder instead
of StringBuffer, or using System.arraycopy() instead of for loops). Others indicate real problems,
like the use of != to compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings about potential
problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message