db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5849) Text for SQL state XSDG0: remove redundant "page"
Date Fri, 06 Jul 2012 15:03:35 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408048#comment-13408048

Dag H. Wanvik commented on DERBY-5849:

Would something like this look better:

The page with page key "Page(1,Container(0, 14929))" could not be read from disk.

We would then need to localize the text "The page with page key" for our supported languages.
Page key is an implementation entity (class PageKey). Would it be beneficial to explain what
the numbers mean in the error message? E.g. 

The page identified by page number 1 in the container identified by container id 14929, segment
0, could not be read from disk."


> Text for SQL state XSDG0: remove redundant "page"
> -------------------------------------------------
>                 Key: DERBY-5849
>                 URL: https://issues.apache.org/jira/browse/DERBY-5849
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services, Store
>            Reporter: Dag H. Wanvik
>            Priority: Trivial
> In the message text (English locale), we see this error being printed for error state
>    Page Page(1,Container(0, 14929)) could not be read from disk. 
> The text in messages.xml is:
>    <text>Page {0} could not be read from disk.</text>
> The problem is that the argument used is a PageKey, which has a toString method thats
>    "Page(" + pageNumber + "," + container.toString() + ")";
> so, we get two "page" string and it looks silly. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message