db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5847) Clean up IDE warnings in DRDAConnThread
Date Tue, 10 Jul 2012 12:04:34 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-5847:
--------------------------------------

    Attachment: d5847-4a-unused-assignment.patch

Attaching d5847-4a-unused-assignment.patch which fixes warnings about values that are assigned
to variables, but never used.

This is typically code where the declaration of a variable happens before it is assigned its
intended value, and the declaration temporarily assigns a value that indicates it's unused
(like null, 0, -1). It is better to leave the variables uninitialized in this case, as then
the compiler will be able to detect and tell us if there are code paths where it's possible
that the variable is not initialized before it's used.

The patch cleans up the warnings by removing the unused assignments and, if possible, moving
the declaration to where the first real assignment happens.

All tests ran cleanly. Committed revision 1359624.
                
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
>                 Key: DERBY-5847
>                 URL: https://issues.apache.org/jira/browse/DERBY-5847
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.10.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5847-1a-string-equality.patch, d5847-2a-unnecessary-return.patch,
d5847-3a-static-fields-and-imports.patch, d5847-4a-unused-assignment.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are harmless
(like static fields accessed via an instance, suggestions about using StringBuilder instead
of StringBuffer, or using System.arraycopy() instead of for loops). Others indicate real problems,
like the use of != to compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings about potential
problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message