db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-5833) Remove unused methods in NetCallableStatement class
Date Mon, 02 Jul 2012 04:36:51 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Pendleton resolved DERBY-5833.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.10.0.0

I checked the svn history for NetCallableStatement.java and
this code was introduced as part of the original contribution
to Derby, and has not been modified since.

I searched the codebase and agree that these two methods
are unused.

Of the two remaining overloads of resetNetCallableStatement,
it seems that the 3-argument version is called only internally,
by the 6-argument version, so it should be possible, if we so
chose, to make the 3-argument version private, as part of some
future change.

My builds and tests were successful, so I committed the
patch to the trunk as revision 1356066.

                
> Remove unused methods in NetCallableStatement class
> ---------------------------------------------------
>
>                 Key: DERBY-5833
>                 URL: https://issues.apache.org/jira/browse/DERBY-5833
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>             Fix For: 10.10.0.0
>
>         Attachments: derby-5833.patch
>
>
> The following methods in NetCallableStatement class seem to be dead code. It might be
possible to remove them. 
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql,
Section section)
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql,
Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message