db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-5826) Remove unused methods in NetConnectionReply class
Date Sun, 01 Jul 2012 17:31:46 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Pendleton resolved DERBY-5826.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.10.0.0

I agree that these methods are not used: I searched the code tree and
could find no uses of these methods; I did a complete clean build with
the patch applied with no errors or messages; the derbynet test suite
passes cleanly with the patch applied.

I committed the patch to the trunk as revision 1355959.


                
> Remove unused methods in NetConnectionReply class
> -------------------------------------------------
>
>                 Key: DERBY-5826
>                 URL: https://issues.apache.org/jira/browse/DERBY-5826
>             Project: Derby
>          Issue Type: Task
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>             Fix For: 10.10.0.0
>
>         Attachments: DERBY-5826.patch
>
>
> Code inspection of the NetConnectionReply class reveals that the following methods are
not used at all.
> - verifyConnectReply(int codept)
> - readDummyExchangeServerAttributes(Connection connection)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3,
boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3,
boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6, boolean receivedFlag7)
> It may be possible to just remove these methods if they are not required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message