db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-436) clean up imports and static field references in DRDA classes
Date Fri, 20 Jul 2012 07:22:34 GMT

     [ https://issues.apache.org/jira/browse/DERBY-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen resolved DERBY-436.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.10.0.0
         Assignee: Knut Anders Hatlen

Thanks, Kathey. I took that as a +1 to the patch, and committed it to trunk with revision
1363662. Marking this issue as resolved.

I'm in favour of making the indentation style consistent, and now is probably as good a time
to do it as any. Making merging difficult has been the main reason why we haven't done it
before. If svn handles that now, I guess the main argument against it would be that it would
be more difficult to check with svn annotate when a code fragment was introduced. But maybe
the same flags could be used with svn annotate.

(I'd probably be in favour of making this change even if the problems with merging and annotation
weren't solved, though. Backporting may be a little painful in the beginning, but the old
branches will become less relevant and backporting to them will happen less frequently as
time passes. The sooner we do it, the sooner the pain will go away. :)
                
> clean up imports and static field references in DRDA classes
> ------------------------------------------------------------
>
>                 Key: DERBY-436
>                 URL: https://issues.apache.org/jira/browse/DERBY-436
>             Project: Derby
>          Issue Type: Task
>          Components: Network Server
>    Affects Versions: 10.1.1.0, 10.2.1.6
>            Reporter: Kathey Marsden
>            Assignee: Knut Anders Hatlen
>             Fix For: 10.10.0.0
>
>         Attachments: d436.diff
>
>
> In DRDA Classes, eg. DRAConnThread.java, and other classes in org.apache.derby.drda,
 Eclipse shows that the imports need to be organized and the static field references need
to be referenced in a static way. It would be good to clean up the warnings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message