db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5873) Avoid unnecessary allocation of Number instances in client/server
Date Thu, 26 Jul 2012 09:48:35 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-5873:

    Attachment: d5873-2a-bigdec.diff

The 2a patch makes CrossConverters and Cursor use BigDecimal.valueOf(double) when converting
a double to a BigDecimal. It also makes Decimal and DDMReader use BigDecimal.valueOf(double,int)
when parsing a BigDecimal with precision up to 18 sent over the wire.

All the regression tests passed.
> Avoid unnecessary allocation of Number instances in client/server
> -----------------------------------------------------------------
>                 Key: DERBY-5873
>                 URL: https://issues.apache.org/jira/browse/DERBY-5873
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client, Network Server
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d5873-1a.diff, d5873-2a-bigdec.diff
> Java 5 introduced some new static factory methods (called valueOf()) in the Number sub-classes,
to be used in preference of the constructors unless a fresh instance is required. The valueOf()
methods are allowed to cache and reuse objects, possibly reducing the allocation/gc cost and
the memory footprint. For example, Integer.valueOf(int) uses a pre-allocated cache for values
between -128 and +127 by default (the cache size can be tuned with JVM flags).
> Now that the server and client code is compiled against Java 5 libraries, we should use
the valueOf() methods  to get those benefits. Note also that Java 5 auto-boxing of numbers
uses these methods implicitly, so in many cases we can just remove the calls to the constructor
and the compiler will automatically insert the calls for us.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message