db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (DERBY-5826) Remove unused methods in NetConnectionReply class
Date Sun, 01 Jul 2012 17:04:45 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Pendleton reassigned DERBY-5826:
--------------------------------------

    Assignee: Mohamed Nufail

I'm reviewing this patch.

I looked at the SVN history for this file
http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetConnectionReply.java?view=annotate

to see if there were any clues about these methods.

The methods identified by this issue appear to have been present since the original submission
of NetConnectionReply in 2005, and have not been modified
since that time, which is a good piece of evidence sugggesting that they are, indeed, unused.
                
> Remove unused methods in NetConnectionReply class
> -------------------------------------------------
>
>                 Key: DERBY-5826
>                 URL: https://issues.apache.org/jira/browse/DERBY-5826
>             Project: Derby
>          Issue Type: Task
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>         Attachments: DERBY-5826.patch
>
>
> Code inspection of the NetConnectionReply class reveals that the following methods are
not used at all.
> - verifyConnectReply(int codept)
> - readDummyExchangeServerAttributes(Connection connection)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3,
boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3,
boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6, boolean receivedFlag7)
> It may be possible to just remove these methods if they are not required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message