db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5853) Test for uncovered methods of BrokeredPreparedStatement
Date Wed, 11 Jul 2012 08:53:35 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411332#comment-13411332
] 

Knut Anders Hatlen commented on DERBY-5853:
-------------------------------------------

I think it would be good to use a similar approach as Nufail currently does with LogicalPreparedStatement
and friends on the client side, and make use of existing tests that currently only test the
PreparedStatement methods in the non-brokered classes, by wrapping them in decorators.

See for example derby-5851-CPdecorator.patch attached to DERBY-5851. By using connectionXADecorator()
instead of connectionCPDecorator(), and not using clientServerDecorator(), I think it would
make the test exercise BrokeredPreparedStatement (or, actually, that specific test will probably
mostly exercise the methods in the subclass BrokeredPreparedStatement40). Unfortunately, there
is a chance that you'll run into the same problems that Nufail saw in DERBY-5851, that the
code coverage tools don't notice that the code is exercised.
                
> Test for uncovered methods of BrokeredPreparedStatement
> -------------------------------------------------------
>
>                 Key: DERBY-5853
>                 URL: https://issues.apache.org/jira/browse/DERBY-5853
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Siddharth Srivastava
>            Assignee: Siddharth Srivastava
>            Priority: Minor
>
> According to emma code coverage report, several methods of BrokeredPreparedStatement
are uncovered. 
> This issue deals with adding tests for those methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message