Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 22 Jun 2012 05:58:42 +0000 (UTC)
From: "Mohamed Nufail (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <1919659551.42896.1340344722789.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1636342018.42856.1340343882495.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (DERBY-5826) Remove unused methods in
 NetConnectionReply class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Nufail updated DERBY-5826:
----------------------------------

    Attachment: DERBY-5826.patch

Attached a patch. This patch removes the 4 methods mentioned above and the method parseConnectError() which is being used only by the removed method verifyConnectReply(int codept)
                
> Remove unused methods in NetConnectionReply class
> -------------------------------------------------
>
>                 Key: DERBY-5826
>                 URL: https://issues.apache.org/jira/browse/DERBY-5826
>             Project: Derby
>          Issue Type: Task
>            Reporter: Mohamed Nufail
>            Priority: Minor
>         Attachments: DERBY-5826.patch
>
>
> Code inspection of the NetConnectionReply class reveals that the following methods are not used at all.
> - verifyConnectReply(int codept)
> - readDummyExchangeServerAttributes(Connection connection)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3, boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6)
> - checkRequiredObjects(boolean receivedFlag, boolean receivedFlag2, boolean receivedFlag3, boolean receivedFlag4, boolean receivedFlag5, boolean receivedFlag6, boolean receivedFlag7)
> It may be possible to just remove these methods if they are not required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira