Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Thu, 14 Jun 2012 10:51:43 +0000 (UTC)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <1487334559.15283.1339671103073.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1427045929.2534.1337143334622.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (DERBY-5764) Make DatabaseMetaDataTest more robust
 wrt changes made by other tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-5764:
-----------------------------------

    Attachment: derby-5764-3a-add_test_case_schema_null.diff

Patch 3a (attached) adds, or reverts, some test cases using null for the schema in the meta data calls.
I factored out some code from JDBC.assertUnsortedResultSet into a helper method and added the new method assertResultSetContains. The latter method asserts that the expected rows are in the result set, but it doesn't care if there are more rows than expected.

I ran the test individually and I also ran the upgrade suite without failures.

Patch ready for review.
                
> Make DatabaseMetaDataTest more robust wrt changes made by other tests
> ---------------------------------------------------------------------
>
>                 Key: DERBY-5764
>                 URL: https://issues.apache.org/jira/browse/DERBY-5764
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.1.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5764-1a-upgraderun_cleanup.diff, derby-5764-2a-specify_schema.diff, derby-5764-3a-add_test_case_schema_null.diff
>
>
> The subset of tests from DatabaseMetaDataTest being run as part of the upgrade tests is sensitive to changes in the database made by other tests. For instance, adding tables with foreign keys will make the test fail due to extra rows in system tables.
> Usually this could be solved by using a single-use db wrapper of some sort, but in the upgrade tests the database will be booted several times with different versions of Derby and the data needs to be preserved between some of these boots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira