db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohamed Nufail (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5786) Duplicate copies of InputStreamUtil.java and DynamicByteArrayOutputStream.java classes in client.net package
Date Sun, 10 Jun 2012 02:00:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292463#comment-13292463
] 

Mohamed Nufail commented on DERBY-5786:
---------------------------------------

Thank you. I've closed the issue.
                
> Duplicate copies of InputStreamUtil.java and DynamicByteArrayOutputStream.java classes
in client.net package
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5786
>                 URL: https://issues.apache.org/jira/browse/DERBY-5786
>             Project: Derby
>          Issue Type: Task
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>             Fix For: 10.10.0.0
>
>         Attachments: DERBY-5786.patch
>
>
> In solving DERBY-4491, InputStreamUtil.java and DynamicByteArrayOutputStream.java classes
which are present in org.apache.derby.iapi.services.io package was needed for the network
client also. So now there are duplicate copies of those classes in org.apache.derby.client.net
package. 
> But the client uses only a small part of the functionality those classes provide. In
a discussion in dev list (http://mail-archives.apache.org/mod_mbox/db-derby-dev/201205.mbox/%3Cwjo8r4ucgtfv.fsf%40oracle.com%3E)
it was decided to use EncodedInputStream.PublicBufferOutputStream which is already in the
client.net package instead of the duplicated classes. In order to do this PublicBufferOutputStream
will first be made into a stand-alone class.
> Doing this would help to reduce the code size and increase code coverage, as the duplicate
classes currently have no code coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message