db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5786) Duplicate copies of InputStreamUtil.java and DynamicByteArrayOutputStream.java classes in client.net package
Date Mon, 04 Jun 2012 01:38:23 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288308#comment-13288308
] 

Bryan Pendleton commented on DERBY-5786:
----------------------------------------

This patch looks very clean to me. My build was clean with the patch applied.
I also ran 'ant javadoc' and it was clean, though I'm not sure if we build JavaDoc
for this particular package (org.apache.derby.client.net.*) or not.

I always like a patch which deletes code! Getting the same thing done with less
code is always a good sign.

Here is the 'svn stat' that I have; does this look right?

A       java/client/org/apache/derby/client/net/PublicBufferOutputStream.java
D       java/client/org/apache/derby/client/net/InputStreamUtil.java
M       java/client/org/apache/derby/client/net/EncodedInputStream.java
D       java/client/org/apache/derby/client/net/DynamicByteArrayOutputStream.java
M       java/client/org/apache/derby/client/net/Request.java

What tests have you run with this patch? I ran

    ant -Dderby.junit.testclass=org.apache.derbyTesting.functionTests.tests.derbynet._Suite
junit-single

and it was clean.

Are there other tests that we need to run to cover this code? Do the derbynet tests from
the old harness add additional coverage here?

I found an old suite named 'derbynetclientmats.runall' and ran it, but I'm not sure if that
adds any additional coverage in this area or not.






                
> Duplicate copies of InputStreamUtil.java and DynamicByteArrayOutputStream.java classes
in client.net package
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5786
>                 URL: https://issues.apache.org/jira/browse/DERBY-5786
>             Project: Derby
>          Issue Type: Task
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>         Attachments: DERBY-5786.patch
>
>
> In solving DERBY-4491, InputStreamUtil.java and DynamicByteArrayOutputStream.java classes
which are present in org.apache.derby.iapi.services.io package was needed for the network
client also. So now there are duplicate copies of those classes in org.apache.derby.client.net
package. 
> But the client uses only a small part of the functionality those classes provide. In
a discussion in dev list (http://mail-archives.apache.org/mod_mbox/db-derby-dev/201205.mbox/%3Cwjo8r4ucgtfv.fsf%40oracle.com%3E)
it was decided to use EncodedInputStream.PublicBufferOutputStream which is already in the
client.net package instead of the duplicated classes. In order to do this PublicBufferOutputStream
will first be made into a stand-alone class.
> Doing this would help to reduce the code size and increase code coverage, as the duplicate
classes currently have no code coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message