db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DERBY-5803) Make error handling in xaHelper more explicit
Date Fri, 08 Jun 2012 11:54:24 GMT
Kristian Waagan created DERBY-5803:
--------------------------------------

             Summary: Make error handling in xaHelper more explicit
                 Key: DERBY-5803
                 URL: https://issues.apache.org/jira/browse/DERBY-5803
             Project: Derby
          Issue Type: Improvement
          Components: Tools
    Affects Versions: 10.10.0.0
            Reporter: Kristian Waagan
            Priority: Trivial


In xaHelper the method handleException returns nothing (void), but it always throws an exception.
Typically used inside a catch-block, this pattern confuses (static) code analyzers and reduces
code readability.

In this case it is possible to make the method return SQLException and write "throw handleException(t)",
which makes it clear that the flow will stop if it reaches the catch block. Note that the
method may still throw a RuntimeException, which I will document in the method Javadoc.

The latter pattern is other places in the Derby code base, but I haven't checked for consistency.
One specific case worth mentioning is the one in DRDAConnThread. This one is different in
that it only takes correct actions, but doesn't actually throw an exception since we wan't
the server thread to keep processing/executing after having cleaned up and informed the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message