Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Thu, 3 May 2012 12:34:50 +0000 (UTC)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1502314557.21448.1336048490691.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <589483063.21430.1336048369845.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (DERBY-5740) Remove unsued code in
 AlterTableConstantaction.columnDroppedAndTriggerDependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-5740:
-----------------------------------

    Attachment: derby-5740-1a-code_removal.diff

Attaching patch 1a.

Both derbyAll and suites.All passed with the patch, which suggests this is indeed unnecessary code and can be removed.

Patch ready for review.
                
> Remove unsued code in AlterTableConstantaction.columnDroppedAndTriggerDependencies
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-5740
>                 URL: https://issues.apache.org/jira/browse/DERBY-5740
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Priority: Trivial
>         Attachments: derby-5740-1a-code_removal.diff
>
>
> The following code is executed, but the results are not used:
> 			CollectNodesVisitor visitor = new CollectNodesVisitor(ColumnReference.class);
> 			stmtnode.accept(visitor);
> 			Vector refs = visitor.getList();  <--- never used
> I plan to remove the code, but just want to record it here in case there are side-effects by using the visitor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira