db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5734) End transaction if CleanDatabaseTestSetup.decorateSQL fails
Date Thu, 03 May 2012 08:46:51 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Kristian Waagan updated DERBY-5734:

    Attachment: derby-5734-1b-end_transaction.diff

Thanks for looking at the patch, Knut.
I rewrote the logic a little and used clearConnection() (no argument passed) in the finally

Regression tests passed.
> End transaction if CleanDatabaseTestSetup.decorateSQL fails
> -----------------------------------------------------------
>                 Key: DERBY-5734
>                 URL: https://issues.apache.org/jira/browse/DERBY-5734
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions:
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5734-1a-end_transaction.diff, derby-5734-1b-end_transaction.diff
> By overriding CleanDatabaseTestSetup.decorateSQL you are allowed to perform tasks as
part of the test setup / decorator. The connection obtainable through the passed in statement
is configured with auto-commit off. If decorateSQL fails the connection may be left active
in the middle of a transaction, which again may cause subsequent tests to fails. I've observed
subsequent tests fail due to locks helds by the statement / connection passed to decorateSQL.
> CleanDatabaseTestSetup.setUp should ensure the transaction is ended regardless of whether
decorateSQL throws an exception or not.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message