db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5783) Remove duplicated code for starting remote processes in replication tests
Date Tue, 29 May 2012 22:36:23 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285202#comment-13285202
] 

Dag H. Wanvik commented on DERBY-5783:
--------------------------------------

Looks like a safe and good cleanup. +1

                
> Remove duplicated code for starting remote processes in replication tests
> -------------------------------------------------------------------------
>
>                 Key: DERBY-5783
>                 URL: https://issues.apache.org/jira/browse/DERBY-5783
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.10.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5783-1a.diff
>
>
> ReplicationRun has two copies of each of the methods runUserCommand(), runUserCommandRemotely()
and processOutput(). One variant takes an id parameter (used only in debug output), and one
doesn't. It would be sufficient to have one copy of each of these methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message