db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-4633) Cache default calendar in result sets and statements on client driver
Date Tue, 08 May 2012 11:13:50 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-4633:
--------------------------------------

    Attachment: Main.java

Thanks for writing the test, Jayaram! I ran it in my environment a couple of times, and saw
that it varied between 21 and 22 seconds with both 10.5.3.0 and 10.6.2.1.

Since most of the time in the test is spent running insert statements, I also ran a modified
version of it a couple of times (see attached file) in case there had been some other changes
between the two versions that would change the performance of insert statements. The modified
version uses a values statement. The altered test didn't show any significant changes (17
seconds both with 10.5.3.0 and 10.6.2.1).

Based on your tests (which ran faster on 10.6.2.1) and mine (which didn't show any differences),
it seems like DERBY-4582 didn't introduce any significant changes in performance. So maybe
we should just close this issue as Won't Fix, rather than trying to come up with a solution
for something that doesn't appear to be a problem? What do you think?
                
> Cache default calendar in result sets and statements on client driver
> ---------------------------------------------------------------------
>
>                 Key: DERBY-4633
>                 URL: https://issues.apache.org/jira/browse/DERBY-4633
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Network Client
>    Affects Versions: 10.6.1.0
>            Reporter: Knut Anders Hatlen
>              Labels: derby_triage10_9
>         Attachments: Main.java, Main.java
>
>
> After the changes in DERBY-4582, these methods now allocate a default calendar object
on each invocation (on the client driver), whereas they didn't before the fix:
> ResultSet.getDate(int)
> ResultSet.getTime(int)
> ResultSet.getTimestamp(int)
> PreparedStatement.setDate(int, java.sql.Date)
> PreparedStatement.setTime(int, java.sql.Time)
> PreparedStatement.setTimestamp(int, java.sql.Timestamp)
> CallableStatement.getDate(int)
> CallableStatement.getTime(int)
> CallableStatement.getTimestamp(int)
> The embedded driver prevents excessive allocation of default calendar objects in these
methods by caching an instance in ConnectionChild (the super-class of EmbedResultSet, EmbedPreparedStatement
and EmbedCallableStatement). We should do something similar on the client driver.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message