db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5791) Replication tests should use BaseTestCase.execJavaCmd() to run local commands
Date Tue, 29 May 2012 22:44:24 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285220#comment-13285220

Dag H. Wanvik commented on DERBY-5791:

Good cleanup, approach is good. I did not vet all the details, but from 10000 feet, +1.
If nothing else, diffstat gave me: 235 insertions(+), 437 deletions, so Derby gets slimmer

> Replication tests should use BaseTestCase.execJavaCmd() to run local commands
> -----------------------------------------------------------------------------
>                 Key: DERBY-5791
>                 URL: https://issues.apache.org/jira/browse/DERBY-5791
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5791-1a.diff
> The replication tests invoke Runtime.exec() directly in order to spawn processes. The
sub-processes that run on the same host as the main test process, should instead be started
with the helper method BaseTestCase.execJavaCmd(). Having all the tests use the helper method
would make it easier if we for example want to pass specific flags to all sub-processes created
in a test run.
> Note that the replication tests also have code for starting processes on a remote host
via ssh. BaseTestCase.execJavaCmd() cannot do that, so only local processes can be started
with the helper method. When the replication tests run as part of suites.All, all the spawned
processes run locally.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message