db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Matrigali (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DERBY-5494) Same value returned by successive calls to a sequence generator flanking an unorderly shutdown.
Date Fri, 25 May 2012 16:38:23 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283582#comment-13283582
] 

Mike Matrigali edited comment on DERBY-5494 at 5/25/12 4:38 PM:
----------------------------------------------------------------

Here is proposed fix for performance degredation of identity columns caused by previous patch.
 All tests passed for me running sane, classes, write sync disabled, and no special handling
for upgrade tests.  I am concerned that tests took a lot longer (9+ hours) vs around 6 hours
for runs in the past on this new machine doing sane, classes, write sync enabled, but I changed
both the write sync option and the patch so don't have a good baseline.  Am running more tests
before commit.

The patch changes some interfaces to allow creaters of nested user transactions to set the
default sync on transaction end when they
create the transaction, rather than just relying on type of transaction.  The previous patch
set the intended behavior for commit but 
abort did not pick up the intended behaviour and it turned out each insert of a identity column
row did commit and then destroy which called abort.  Gets rid of the previous routine which
would check type of xact for every commit so should eliminate some small codepath also.  
                
      was (Author: mikem):
    Here is proposed fix for performance degredation of identity columns caused by previous
patch.  All tests passed for me running sane, classes, write sync disabled, and no special
handling for upgrade tests.  I am concerned that tests took a lot longer (9+ hours) vs around
6 hours for runs in the past on this new machine doing sane, classes, write sync enabled,
but I changed both the write sync option and the patch so don't have a good baseline.  Am
running more tests before commit.
                  
> Same value returned by successive calls to a sequence generator flanking an unorderly
shutdown.
> -----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5494
>                 URL: https://issues.apache.org/jira/browse/DERBY-5494
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2, 10.8.2.2, 10.9.1.0
>            Reporter: Rick Hillegas
>            Assignee: Mike Matrigali
>              Labels: derby_triage10_9
>         Attachments: derby-5494_3.diff, derby-5494_diff_1a.txt, derby-5494_diff_2.txt
>
>
> The following sequence of steps causes a sequence generator to return the same value
on successive NEXT VALUE FOR calls.
> 1) Bring up ij and issue the following commands:
> connect 'jdbc:derby:db;create=true';
> create sequence s;
> values next value for s; 
> 2) Control-c out of ij so that the engine comes down hard without an orderly shutdown.
> 3) Now bring up ij again and issue the following commands:
> connect 'jdbc:derby:db';
> values next value for s; 
> Thanks to Knut for finding this one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message