db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5746) Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
Date Tue, 15 May 2012 09:56:27 GMT



























<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2)
{
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px
solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img
src="https://issues.apache.org/jira/s/en_UKy3do2c/731/4/_/images/asf_logo_wide.gif" alt=""
style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%"
style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://issues.apache.org/jira/secure/useravatar?avatarId=10452"
alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px
0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="knutanders" id="email_knutanders"
href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=knutanders" style="color:#326ca6;">Knut
Anders Hatlen</a>
     commented on <img src="https://issues.apache.org/jira/images/icons/improvement.gif"
height="16" width="16" border="0" align="absmiddle" alt="Improvement"> <a style='color:#326ca6;text-decoration:none;'
href='https://issues.apache.org/jira/browse/DERBY-5746'>DERBY-5746</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px
0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://issues.apache.org/jira/browse/DERBY-5746'><strong>Minor
refactoring of DataDictionaryImpl.getSetAutoincrementValue</strong></a>
            </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;"
width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0
0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">All
the other callers of the various overloads of ConglomerateController.fetch() in DataDictionaryImpl
(except one occurrence in updateCurrentSequenceValue()) either use the returned value or checks
it in an assert. Perhaps we should do the same here for consistency?
<br/>

<br/>
The other change, which narrows the scope of the bit set, looks like a good improvement.</div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding:
0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;'
href='https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br
/>
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

Mime
View raw message