Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Wed, 25 Apr 2012 11:20:04 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <801169006.285.1335352804960.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <291646607.4515.1335179735350.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Closed] (DERBY-5704) Various cleanups in CoalesceTest
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen closed DERBY-5704.
-------------------------------------

          Resolution: Fixed
       Fix Version/s: 10.9.0.0
    Issue & fix info:   (was: Patch Available)

Committed revision 1330195.
                
> Various cleanups in CoalesceTest
> --------------------------------
>
>                 Key: DERBY-5704
>                 URL: https://issues.apache.org/jira/browse/DERBY-5704
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d5704-1a.diff
>
>
> I noticed a couple of things that could be cleaned up in CoalesceTest:
> - It keeps statements in instance variables. These are closed in tearDown(), but not nulled out, so they are not gc'ed when the test completes.
> - It has much code that follows the pattern
>   try {
>      s.execute(...);
>   } catch (SQLException sqle) {
>      assertSQLState(state, sqle);
>   }
> which means it won't report a failure if the execution of the statement succeeds unexpectedly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira