Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Tue, 24 Apr 2012 10:17:34 +0000 (UTC)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <415720131.8929.1335262654202.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2146887115.8878.1335260974195.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DERBY-5706) Clean up statements in
 CreateTableFromQueryTest
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260410#comment-13260410 ] 

Kristian Waagan commented on DERBY-5706:
----------------------------------------

Looks good, +1. I ran the test with and without the patch.
                
> Clean up statements in CreateTableFromQueryTest
> -----------------------------------------------
>
>                 Key: DERBY-5706
>                 URL: https://issues.apache.org/jira/browse/DERBY-5706
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5706-1a.diff
>
>
> CreateTableFromQueryTest has a Statement field that it closes, but doesn't null out, in tearDown(). Since the field isn't nulled out, it cannot be garbage collected, and one Statement per test case will be left on the heap after completion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira