Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 20 Apr 2012 21:33:34 +0000 (UTC)
From: "Kathey Marsden (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1649588142.140.1334957614904.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1234101262.6063.1325705139573.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (DERBY-5565) Network Server should reject client
 connections that are not Derby Network Client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden updated DERBY-5565:
----------------------------------

    Attachment: JCCDSConnectTest.java
                derby.log
                derby-5565_diff.txt

Attached is a patch for this issue, sample derby.log when JCC tries to connect and the program I used to try to connect with JCC. 

If a non-derby client tries to connect, we will throw a  requiredValueNotFound SYNTAXRM error and log a more informative error to derby.log:

Fri Apr 20 14:22:44 PDT 2012 : ERROR UNSUPPORTED CLIENT: Invalid client product id JCC03580, Derby Network Client (DNC)
is the only supported client Product
Followed by the SYNTAXRM error.


Running tests now.


> Network Server should reject client connections that are not Derby Network Client
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-5565
>                 URL: https://issues.apache.org/jira/browse/DERBY-5565
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.9.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: JCCDSConnectTest.java, derby-5565_diff.txt, derby.log
>
>
> Since there have been no other network clients besides Derby Network Client  tested or supported with Derby since 10.1 and since any protocol based client needs to understand Derby's DRDA extensions, deviations, and stored procedure usage.  I think it would be a good idea in 10.9 for Network Server to  outright reject any network clients that are not Derby Network Client.
> This would eliminate confusion up front for those that might not be aware that the DB2 Universal JDBC Driver and DB2 Runtime Client are not supported.  They would get a clean reasonable error instead of hitting various protocol errors.
> Also it would mean if someone does want to add support for some network client in the future they would at least need to add the one or two lines of code in AppRequester to identify it, which I think would be a good thing.
> I think the code change would not be hard but the biggest impact might be anyone who still runs tests with JCC on trunk would need to disable those tests. There is a separate issue DERBY-4785 that Jayaram is working on to complete remove the JCC related code from the tests and test infrastructure.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira