Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D327F907A for ; Mon, 9 Apr 2012 13:33:41 +0000 (UTC) Received: (qmail 53860 invoked by uid 500); 9 Apr 2012 13:33:41 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 53836 invoked by uid 500); 9 Apr 2012 13:33:41 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 53829 invoked by uid 99); 9 Apr 2012 13:33:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2012 13:33:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2012 13:33:39 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0889B361C04 for ; Mon, 9 Apr 2012 13:33:18 +0000 (UTC) Date: Mon, 9 Apr 2012 13:33:18 +0000 (UTC) From: "Kristian Waagan (Closed) (JIRA)" To: derby-dev@db.apache.org Message-ID: <1361266040.2569.1333978398058.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1106852785.32962.1331120217935.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Closed] (DERBY-5641) Remove unused BaseDataFileFactory methods plus minor cleanups MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan closed DERBY-5641. ---------------------------------- Closing. > Remove unused BaseDataFileFactory methods plus minor cleanups > ------------------------------------------------------------- > > Key: DERBY-5641 > URL: https://issues.apache.org/jira/browse/DERBY-5641 > Project: Derby > Issue Type: Improvement > Components: Store > Affects Versions: 10.9.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.9.0.0 > > Attachments: derby-5641-1a-unused_methods_plus_cleanup.diff > > > BaseDataFileFactory has some unused methods, they can be removed: syncSideLog, pageToDirty and getTempDirectory > In addition I suggest the following cleanups: > o remove unused imports > o remove unnecessary return statement > o make synchronization object freezeSemaphore final > o remove unused instance variable backupPath > o remove unused local variable (and exception instantiation) multipleJBMSWarning > o replace new Boolean with Boolean.valueOf -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira