Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Tue, 17 Apr 2012 11:46:20 +0000 (UTC)
From: "Kristian Waagan (Resolved) (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1272769614.32498.1334663180255.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (DERBY-2031) Convert derbynet/testProtocol.java
 to JUnit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan resolved DERBY-2031.
------------------------------------

          Resolution: Fixed
    Issue & fix info:   (was: Patch Available)

Committed patch 7a, including the deletions, to trunk with revision 1327050.
I fixed a few lines in the patch where I had used a mix of tabs and spaces for indentation.

This finally concludes the work for this JIRA - there is now only one version of the test, and it is being run as part of suites.All.
                
> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
>                 Key: DERBY-2031
>                 URL: https://issues.apache.org/jira/browse/DERBY-2031
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Test
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat, derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat, derby-2031-3b-enable_test.diff, derby-2031-4a-close_streams.diff, derby-2031-5a-new_adapter.diff, derby-2031-5a-new_adapter.stat, derby-2031-5b-new_adapter.diff, derby-2031-6a-pptesting_removal.diff, derby-2031-6a-pptesting_removal.stat, derby-2031-7a-old_harness_test_removal.diff, derby-2031-7a-old_harness_test_removal.stat, derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a special-purpose language. The statements are very much like assertions, so it should be fairly easy to convert the test to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail() instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println(). It should also use TestConfiguration to get the host name and port number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira