db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5704) Various cleanups in CoalesceTest
Date Mon, 23 Apr 2012 11:27:40 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-5704:

    Attachment: d5704-1a.diff

The attached patch makes the following changes:

- Remove the instance variables s and ps, and instead create local variables where needed.
This allows us to remove setUp() and tearDown(), and not worrying about closing/nulling out
the statements.

- Replace try/catch/assertSQLState with assertCompileError() and assertStatementError() where

- Add missing fail() call to remaining try/catch/assertSQLState blocks.
> Various cleanups in CoalesceTest
> --------------------------------
>                 Key: DERBY-5704
>                 URL: https://issues.apache.org/jira/browse/DERBY-5704
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5704-1a.diff
> I noticed a couple of things that could be cleaned up in CoalesceTest:
> - It keeps statements in instance variables. These are closed in tearDown(), but not
nulled out, so they are not gc'ed when the test completes.
> - It has much code that follows the pattern
>   try {
>      s.execute(...);
>   } catch (SQLException sqle) {
>      assertSQLState(state, sqle);
>   }
> which means it won't report a failure if the execution of the statement succeeds unexpectedly.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message