db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5565) Network Server should reject client connections that are not Derby Network Client
Date Tue, 24 Apr 2012 16:11:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260679#comment-13260679

Kathey Marsden commented on DERBY-5565:

I beleive it is SQL according to https://collaboration.opengroup.org/dbiop/uploads/40/9358/drda-pid.htm?gpid=453&type=doc&id=9358&fn=drda-pid.htm

The Network Server code  where it branched for ODBC  used the shorter exception parameter
length as the default  and did not identify address it as CCC. The patch does take the CCC
references out of AppRequester, eg.

- static final int CCC_CLIENT = 2;		// not yet supported.

-                       default:
-                       // Default is the max for C clients, since that is more
-                       // restricted than for JCC clients.  Note, though, that
-                       // JCC clients are the only ones supported right now.
-                               return Limits.DB2_CCC_MAX_EXCEPTION_PARAM_LENGTH;
-               }

I am not sure what other code is in there that could or should be stripped out. I think there
are some stored procedures for ODBC style metadata.  I don't plan to touch them as part of
this issue.  As they are generic to ODBC and not the DB2 client specifically, I thought it
might be good to keep them in case someone ever does want to make an ODBC driver for Derby.


> Network Server should reject client connections that are not Derby Network Client
> ---------------------------------------------------------------------------------
>                 Key: DERBY-5565
>                 URL: https://issues.apache.org/jira/browse/DERBY-5565
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions:
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: JCCDSConnectTest.java, derby-5565_diff.txt, derby.log
> Since there have been no other network clients besides Derby Network Client  tested or
supported with Derby since 10.1 and since any protocol based client needs to understand Derby's
DRDA extensions, deviations, and stored procedure usage.  I think it would be a good idea
in 10.9 for Network Server to  outright reject any network clients that are not Derby Network
> This would eliminate confusion up front for those that might not be aware that the DB2
Universal JDBC Driver and DB2 Runtime Client are not supported.  They would get a clean reasonable
error instead of hitting various protocol errors.
> Also it would mean if someone does want to add support for some network client in the
future they would at least need to add the one or two lines of code in AppRequester to identify
it, which I think would be a good thing.
> I think the code change would not be hard but the biggest impact might be anyone who
still runs tests with JCC on trunk would need to disable those tests. There is a separate
issue DERBY-4785 that Jayaram is working on to complete remove the JCC related code from the
tests and test infrastructure.  

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message