db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5734) End transaction if CleanDatabaseTestSetup.decorateSQL fails
Date Mon, 30 Apr 2012 10:22:48 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264865#comment-13264865
] 

Knut Anders Hatlen commented on DERBY-5734:
-------------------------------------------

Looks like a useful fix. +1

If you call JDBC.cleanup(conn) or clearConnection(conn) instead, the connection will be closed
too. The latter will additionally clear the conn instance variable. But I suppose rollback()
would be enough to get the tests going again in most cases.
                
> End transaction if CleanDatabaseTestSetup.decorateSQL fails
> -----------------------------------------------------------
>
>                 Key: DERBY-5734
>                 URL: https://issues.apache.org/jira/browse/DERBY-5734
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5734-1a-end_transaction.diff
>
>
> By overriding CleanDatabaseTestSetup.decorateSQL you are allowed to perform tasks as
part of the test setup / decorator. The connection obtainable through the passed in statement
is configured with auto-commit off. If decorateSQL fails the connection may be left active
in the middle of a transaction, which again may cause subsequent tests to fails. I've observed
subsequent tests fail due to locks helds by the statement / connection passed to decorateSQL.
> CleanDatabaseTestSetup.setUp should ensure the transaction is ended regardless of whether
decorateSQL throws an exception or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message