Return-Path: 
 <derby-dev-return-93883-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
X-Original-To: apmail-db-derby-dev-archive@www.apache.org
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3E26C9136
	for <apmail-db-derby-dev-archive@www.apache.org>;
 Fri,  2 Mar 2012 18:40:19 +0000 (UTC)
Received: (qmail 58237 invoked by uid 500); 2 Mar 2012 18:40:19 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 58211 invoked by uid 500); 2 Mar 2012 18:40:19 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 58204 invoked by uid 99); 2 Mar 2012 18:40:19 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 18:40:19 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 18:40:17 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id B5B375148
	for <derby-dev@db.apache.org>; Fri,  2 Mar 2012 18:39:57 +0000 (UTC)
Date: Fri, 2 Mar 2012 18:39:57 +0000 (UTC)
From: "Dag H. Wanvik (Commented) (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <265422696.13065.1330713597745.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <85520529.15364.1311853389536.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DERBY-5357) SQLJ.INSTALL_JAR shouldn't use
 identifier as file name
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/DERBY-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221138#comment-13221138 ] 

Dag H. Wanvik commented on DERBY-5357:
--------------------------------------

Btw, Rick's case 4) would be covered by the patch with the change to JarUtil.mkExternalName, too. [UpdateLoader#initializeFromClasspath -> JarLoader#initialize- > BasicDatabase#getJarFile -> mkExternalName]. But the patch is obviously lacking: we need to tackle the unique mapping problem as well as the upgrade problem, since existing usages of file separators in SQL ids could have been bona fide, e.g. : "a/b", although unlikely as an SQL name, would have worked just fine earlier and should not break on upgrade.

                
> SQLJ.INSTALL_JAR shouldn't use identifier as file name
> ------------------------------------------------------
>
>                 Key: DERBY-5357
>                 URL: https://issues.apache.org/jira/browse/DERBY-5357
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Dag H. Wanvik
>              Labels: derby_triage10_9
>         Attachments: derby-5357.diff, derby-5357.stat
>
>
> When installing a jar file with the SQLJ.INSTALL_JAR procedure, it will copy the jar file to a subdirectory of the database directory. The name of the stored jar file is based on the qualified name specified by the second parameter in the procedure, and becomes something like: <DBDIR>/jar/<SCHEMA>/<JAR_NAME>.jar.<VERSION>
> This naming scheme is problematic because the qualified name of the jar file is an SQL identifier and may contain any characters, also characters with special meaning to the underlying file system.
> One example is this call:
> ij> call sqlj.install_jar('/path/to/toursdb.jar', 'APP."../../../x/jar"', 0);
> 0 rows inserted/updated/deleted
> On Unix-like systems, this will install the jar in a subdirectory of the database directory's parent directory, which is clearly unfortunate as the database directory should be self-contained (an assumption used when taking backup of a database using operating system commands, or when moving the database to another location).
> There's probably also a possibility that INSTALL_JAR fails if the identifier contains a character that's not allowed in file names on the platform.
> It would be better if the jars were stored in a file whose name is independent of the identifier used, so that any valid SQL identifier could be used to name a jar file in the database without causing problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira